Add fragment composition support for JS::File#35
Merged
sbsoftware merged 2 commits intoreleases/v1.8.0from Feb 19, 2026
Merged
Conversation
sbsoftware
reviewed
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds fragment composition to
JS::Fileso multiple independent JS contributions can be appended into a single file output in deterministic order, including reopen-style class usage.Changes
js_fragmentmacro onJS::Filefor explicit fragment contribution.JS::Fileemission to:js_classandjs_functionoutput,def_to_jscompatible by routing it through the same fragment registration path.JS::Moduleoutput wrapping to usesuper(io)for compatibility with the new file-level composition flow.spec/js/file/fragment_composition_spec.crto cover:js_function,js_fragment, anddef_to_js.Validation
crystal tool format --check src specCRYSTAL_CACHE_DIR=/tmp/.crystal-cache-js crystal spec(56 examples, 0 failures)