This repository was archived by the owner on Dec 8, 2023. It is now read-only.
Handle invalid SSDP responses from a Unifi controller#35
Merged
Conversation
Owner
|
Looks like a good patch. It would be neat to fix this bug for the async version as well. I'll see what I can do. |
Owner
|
Alright it's been published as 0.7.1 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my network I have a Ubiquiti Unifi controller that for some reason responds to the SSDP packet as well as the actual network gateway. The response from the Unifi controller is invalid and causes the rust-igd code to fail. This small patch handles this case more gracefully.