Use lint***Filter instead of ***LintKeys for more reliable tests

[xirc]

Use lint***Filter instead of ***LintKeys for more reliable tests.
I have found this improvement when I attempted to solve the issue #5849.

Problem

lintUnusedTask passes the result of lintExcludeFilter as the argument to lintUnused.

sbt/main/src/main/scala/sbt/internal/LintUnused.scala

Lines 60 to 69 in 28833db

	def lintUnusedTask: Def.Initialize[InputTask[Unit]] = Def.inputTask {
	val _ = Def.spaceDelimited().parsed // not used yet
	val state = Keys.state.value
	val log = streams.value.log
	val includeKeys = (lintIncludeFilter in Global).value
	val excludeKeys = (lintExcludeFilter in Global).value
	val result = lintUnused(state, includeKeys, excludeKeys)
	if (result.isEmpty) log.success("ok")
	else lintResultLines(result) foreach { log.warn(_) }
	}

lintExcludeFilter excludes watch related settings which has the prefix watch.

sbt/main/src/main/scala/sbt/internal/LintUnused.scala

Lines 24 to 27 in 28833db

	lintExcludeFilter := {
	val excludes = excludeLintKeys.value.map(_.scopedKey.key.label)
	keyName => excludes(keyName) || keyName.startsWith("watch")
	},

But, in the test, excludeLintKeys are passed to lintUnused.
excludeLintKeys are used in lintExcludeFilter, and it doesn't exclude watch related settings.
Thus, excluding watch related settings from lint keys are not well tested.

sbt/sbt/src/sbt-test/project/lint/build.sbt

Lines 11 to 13 in 28833db

	val includeKeys = (includeLintKeys in Global).value map { _.scopedKey.key.label }
	val excludeKeys = (excludeLintKeys in Global).value map { _.scopedKey.key.label }
	val result = sbt.internal.LintUnused.lintUnused(state, includeKeys, excludeKeys)

I think I can say same thing also about lintIncludeFilter and includeLintKeys.

Solution

• Use lintExcludeFilter instead of excludeLintKeys in the test
• Use lintIncludeFilter instead of includeLintKeys in the test

[eed3si9n]

Thanks @xirc!