This repository was archived by the owner on Sep 3, 2024. It is now read-only.
Conversation
kosteman
reviewed
Feb 12, 2019
| * @return an object found by specified key | ||
| */ | ||
| public static <T> T getValue(String key) { | ||
| public static <T> T getValue(String key) throws DataException { |
Contributor
There was a problem hiding this comment.
Теперь во всех методах где используется взятие значение из стеша придется придется добавлять throws DataException в сигнатуру. Мы точно этого хотим? Может рантайм бросать всё же?
Contributor
Author
There was a problem hiding this comment.
вот я этого очень сильно не хочу, но у вас почему-то все вообще исключения обязывают их прокидывать. Думала, это правило. Если нет, скажи что нужно кидать или может запилить ошибку какую для этого случая?
Contributor
There was a problem hiding this comment.
Ну мне больше нравиться решение создать какого-нибудь StashKeyNotFoundException который наследует RuntimeException и кидать его
Contributor
Author
There was a problem hiding this comment.
Окей, сейчас сделаю
change type exception
kosteman
approved these changes
Feb 12, 2019
clicman
approved these changes
Feb 12, 2019
clicman
approved these changes
Mar 22, 2019
clicman
added a commit
to sbtqa/page-factory-2
that referenced
this pull request
Mar 22, 2019
Features: * Get non-value as json string sbtqa/datajack#31 * Strict key existance for Stash sbtqa/datajack#30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавила обработку ситуации, когда ключ не найден