Conversation
- Fix invalid start_url from domain string to "/"
- Use defaults: { format: } in routes instead of format: constraint
- Replace render file: with render template: in PwaController
- Rename service-worker.js to service_worker.js for Rails view lookup
* Skip caching HTML responses in service worker to avoid stale CSRF tokens * Align manifest theme_color with meta tag (#9F0000) * Remove success console.log from service worker registration * Add trailing newlines to pwa files
katiez667
changed the title
merichar
changed the title
merichar
approved these changes
Feb 27, 2026
katiez667
added a commit
that referenced
this pull request
Mar 20, 2026
* feat: added manifest.json.erb and service-worker.js for pwa
* fix: icon photos for manifest.json.erb
* fix: run db:migrate to apply changes
* feat: pwa_controller.rb, pwa.js, offline.html for pwa
* fix: correct pwa manifest start_url, routes, and controller rendering
- Fix invalid start_url from domain string to "/"
- Use defaults: { format: } in routes instead of format: constraint
- Replace render file: with render template: in PwaController
- Rename service-worker.js to service_worker.js for Rails view lookup
* fix(pwa): address pr review feedback
* Skip caching HTML responses in service worker to avoid stale CSRF tokens
* Align manifest theme_color with meta tag (#9F0000)
* Remove success console.log from service worker registration
* Add trailing newlines to pwa files
---------
Co-authored-by: Katie Zhang <zhangmy667@gmail.com>
Co-authored-by: Katie Zhang <mengyua3@andrew.cmu.edu>
Co-authored-by: Meg Richards <merichar@merichar.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.