Conversation
- Override get_vacuum_points to divide crop_area by CONGA_SCALE, restoring calibration points to original vacuum coordinate space. - Override async_get_rooms_attributes to divide room outline and centre x/y by CONGA_SCALE, restoring room data to vacuum space. - Bump version to 0.3.2.
…3.2 (#77) (#78) - Override get_vacuum_points to divide crop_area by CONGA_SCALE, restoring calibration points to original vacuum coordinate space. - Override async_get_rooms_attributes to divide room outline and centre x/y by CONGA_SCALE, restoring room data to vacuum space. - Bump version to 0.3.2.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe PR adds coordinate rescaling to the Conga map handler to convert room outline and center coordinates from pre-scaled map space back to original vacuum coordinates by dividing by ChangesConga Room Coordinate Rescaling
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Solve the rotation trims applied to the image keeping up, left and down, right order correctly.
Summary by CodeRabbit
Bug Fixes
Chores