Skip to content

Conversation

@ChristopherLi05
Copy link
Member

Addresses #9

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a live service feature that enables real-time telemetry streaming from devices through WebSocket connections. The implementation includes a factory pattern for creating device connections, async message handling, and a decorator-based subscription system for raw telemetry data.

  • Factory pattern implementation for creating devices and WebSocket connections
  • Device class with decorator-based subscription to raw telemetry data
  • WebSocket connection management with async message handling
  • Comprehensive test suite covering connection factories, devices, and WebSocket functionality

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/scadable/live_query/__init__.py Exports main classes for the live query module
src/scadable/live_query/live_telemetry.py Implements DeviceFactory and Device classes for telemetry handling
src/scadable/live_query/connection_type.py Defines connection abstractions and WebSocket implementation
src/scadable/__init__.py Updates main module to include live_query
tests/test_live_query.py Tests for device factory and connection functionality
tests/test_connection_type.py Tests for WebSocket connection implementation
pyproject.toml Adds websockets and pytest-asyncio dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ChristopherLi05
Copy link
Member Author

@crypto-a

Copy link
Contributor

@crypto-a crypto-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Code

@crypto-a
Copy link
Contributor

Would fix the naming but that can be done later on

@crypto-a crypto-a merged commit ec18084 into main Sep 25, 2025
7 checks passed
@crypto-a crypto-a deleted the 9/live-service-auth branch September 25, 2025 22:28
@ChristopherLi05 ChristopherLi05 restored the 9/live-service-auth branch October 5, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants