-
Notifications
You must be signed in to change notification settings - Fork 0
Live Service #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Service #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a live service feature that enables real-time telemetry streaming from devices through WebSocket connections. The implementation includes a factory pattern for creating device connections, async message handling, and a decorator-based subscription system for raw telemetry data.
- Factory pattern implementation for creating devices and WebSocket connections
- Device class with decorator-based subscription to raw telemetry data
- WebSocket connection management with async message handling
- Comprehensive test suite covering connection factories, devices, and WebSocket functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/scadable/live_query/__init__.py |
Exports main classes for the live query module |
src/scadable/live_query/live_telemetry.py |
Implements DeviceFactory and Device classes for telemetry handling |
src/scadable/live_query/connection_type.py |
Defines connection abstractions and WebSocket implementation |
src/scadable/__init__.py |
Updates main module to include live_query |
tests/test_live_query.py |
Tests for device factory and connection functionality |
tests/test_connection_type.py |
Tests for WebSocket connection implementation |
pyproject.toml |
Adds websockets and pytest-asyncio dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…handlers being added and some not, now it just throws runtime error and no handlers are added
crypto-a
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Code
|
Would fix the naming but that can be done later on |
Addresses #9