Initial implementation, ported from the core repository. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @gzm0? |
gzm0
approved these changes
Dec 12, 2017
build.sbt
Outdated
| val scalaJSScalaVersions = | ||
| settingKey[Seq[String]]("All the minor versions of Scala for which to build the CLI") | ||
|
|
||
| // Derived settings |
There was a problem hiding this comment.
Maybe "computed" settings? Derived actually means something in sbt land :-/
There was a problem hiding this comment.
Good point. I'll change it.
Compared to the code from the core repository, the sbt build is in charge of more operations than was `assemble-cli.sh`. In particular, it has taken over the tasks of: * finding the jars to include in `lib/` (most of them are now downloaded through ivy resolution, which a .sh can hardly do), * processing the shell scripts to replace the version numbers, and * laying out the contents of the archives. The script `assemble-cli.sh` is only responsible of invoking the `cliPack` task in sbt, and create the zip and tgz archives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to the code from the core repository, the sbt build is in charge of more operations than was
assemble-cli.sh. In particular, it has taken over the tasks of:lib/(most of them are now downloaded through ivy resolution, which a .sh can hardly do),The script
assemble-cli.shis only responsible of invoking thecliPacktask in sbt, and create the zip and tgz archives.