Accept main methods with no arguments #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
tweaking
branch
from
59f93cb to
0831e28
Compare
|
Just changed the syntax to an option. That's |
sjrd
requested changes
Mar 23, 2022
Useful to run tests for example
alexarchambault
force-pushed
the
tweaking
branch
from
0831e28 to
05316ba
Compare
sjrd
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to specify a main method accepting no arguments, which is useful to use methods such as
org.scalajs.testing.bridge.Bridge.startas an entrypoint, and tweaks minor other things (.bspin.gitignore, default to Scala 2.13.x).Right now, arg-less entrypoints can be specified like
--mainMethod org.scalajs.testing.bridge.Bridge.start!(!at the end of the method name), but let me know if you'd prefer those to be specified another way.These changes are motivated by VirtusLab/scala-cli#676, which runs the Scala.JS linker in an external process, rather than embedding it in the Scala CLI native image.