Implement Web Cryptography API #124
Conversation
mseddon
force-pushed
the
webcrypto-api
branch
2 times, most recently
from
5458cab to
118372b
Compare
There was a problem hiding this comment.
Would it make sense to put this in org.scalajs.dom.crypto instead?
There was a problem hiding this comment.
I strongly agree. org.scalajs.dom.raw is rather cluttered. I'm unsure why pretty much everything is defined in here.
There was a problem hiding this comment.
I don't think this is needed. I would encourage people to use org.scalajs.dom.crypto.crypto instead of org.scalajs.dom.window.crypto.
mseddon
force-pushed
the
webcrypto-api
branch
3 times, most recently
from
7afe44e to
6e7d65e
Compare
|
Okay, I figured out my bizarre crash- the Window.crypto member in dom (when I previously mixed GlobalCrypto into Window) was conflicting with my crypto package object, and the compiler wasn't handling it particularly well. That should be the lot, hopefully! All operations now happen through crypto.crypto as suggested. |
mseddon
force-pushed
the
webcrypto-api
branch
2 times, most recently
from
b7c9ceb to
a1519e5
Compare
|
Whoops, forgot to remove those spurious Algorithm parameter overloads on the Crypto object. |
There was a problem hiding this comment.
Ah ah now you have the worst both worlds: modulusLength of type Long, and not .toDouble. You need either of those. As I told earlier, I would advocate declaring modulusLength as a Double.
Possibly with an overload taking a Long and calling the Double version with .toDouble.
|
That's all. |
|
Thanks again for your patience :) It's been nearly a year since I did any serious commits, so I'm a little rusty. |
|
LGTM |
2 participants
Implements http://www.w3.org/TR/WebCryptoAPI/