Skip to content

Honor timeout parameter in extensions.Ajax.apply #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2014
Merged

Honor timeout parameter in extensions.Ajax.apply #37

merged 1 commit into from
Jul 3, 2014

Conversation

@rinfield
Copy link
Contributor

@rinfield rinfield commented Jul 3, 2014

Apparently, the timeout parameter for extensions.Ajax.apply is ignored.
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Synchronous_and_Asynchronous_Requests#Example.3A_using_a_timeout

When timeout occurs, req would be readyState == 4 // DONE and status == 0, so apply returns Failure(AjaxException(req)).

@sjrd
Copy link
Member

sjrd commented Jul 3, 2014

Review by @lihaoyi

lihaoyi added a commit that referenced this pull request Jul 3, 2014
@lihaoyi
Merge pull request #37 from rinfield/topic/AjaxTimeout
afe9542 
Honor timeout parameter in extensions.Ajax.apply
@lihaoyi lihaoyi merged commit afe9542 into scala-js:master Jul 3, 2014
@lihaoyi
Copy link
Contributor

lihaoyi commented Jul 3, 2014

Looks good to me, thanks!

@rinfield rinfield deleted the topic/AjaxTimeout branch July 3, 2014 20:44
@ochrons ochrons mentioned this pull request Feb 21, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rinfield @sjrd @lihaoyi