Skip to content

Conversation

@sjrd
Copy link
Member

@sjrd sjrd commented Nov 29, 2014

No description provided.

@sjrd
Copy link
Member Author

sjrd commented Nov 29, 2014

Review by @gzm0
/cc @lihaoyi

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@gzm0
Copy link
Contributor

gzm0 commented Nov 29, 2014

LGTM so far

@lihaoyi
Copy link
Contributor

lihaoyi commented Nov 30, 2014

I'm having problems upgrading workbench. This code:

updateBrowsers <<= updateBrowsers.triggeredBy(fastOptJS)

Is giving me

Reference to undefined setting:

  *:fastOptJS from *:updateBrowsers (/Users/haoyi/Dropbox (Personal)/Workspace/workbench/example/build.sbt:28)

Any idea what's up? This SBT stuff confuses me

@sjrd
Copy link
Member Author

sjrd commented Nov 30, 2014

You probably need to use fastOptJS in Compile, although I don't know why it worked before.

@lihaoyi
Copy link
Contributor

lihaoyi commented Nov 30, 2014

Do we want to add these to the announcement? Technically not core-scala-js, but people will probably care:

  • scalarx: 0.2.7-M1
  • scalatags: 0.4.3-M1
  • autowire: 0.2.4-M1
  • utest: 0.2.5-M1
  • upickle: 0.2.6-M1

I've tested them all under fastOpt and fullOpt; things seem to work. I've got workbench running using 0.6.0-M1 which depends on autowire/upickle from maven central, and it works.

@sjrd
Copy link
Member Author

sjrd commented Nov 30, 2014

Yes, absolutely. I was going to ;-)

@sjrd
Copy link
Member Author

sjrd commented Nov 30, 2014

Updated. Should be ready now.
I suggest waiting until tomorrow morning CET (= middle of the night in the US) for the announcement, so that we don't announce on a Sunday.

@sjrd sjrd force-pushed the release-0.6.0-M1 branch 2 times, most recently from 2352bd7 to 6b1d629 Compare November 30, 2014 17:41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No space before % in English.

@gzm0
Copy link
Contributor

gzm0 commented Nov 30, 2014

Also add link to dom-api (in new commit?)

@gzm0
Copy link
Contributor

gzm0 commented Nov 30, 2014

That's all. OK to announce tomorrow morning.

@sjrd
Copy link
Member Author

sjrd commented Nov 30, 2014

Updated.

@gzm0
Copy link
Contributor

gzm0 commented Nov 30, 2014

LGTM

@sjrd sjrd changed the title DO NOT MERGE Announcing 0.6.0-M1 Announcing 0.6.0-M1 Nov 30, 2014
sjrd added a commit that referenced this pull request Dec 1, 2014
@sjrd sjrd merged commit f8aeb24 into scala-js:master Dec 1, 2014
@sjrd sjrd deleted the release-0.6.0-M1 branch January 12, 2015 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants