Skip to content

Conversation

@sjrd
Copy link
Member

@sjrd sjrd commented Jan 23, 2016

@sjrd
Copy link
Member Author

sjrd commented Jan 23, 2016

Review by @gzm0, @nicolasstucki and anyone else who wants to.

@sjrd sjrd force-pushed the scalajs-0.6.6 branch 6 times, most recently from 4df047a to a9fa5cc Compare January 23, 2016 17:59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads a bit hard. How about:

"The new methods isDevelopmentMode and isProductionMode allow you to query in your code whether you are running in a Development build or a Production build (for all ...). The methods are located in [scala.scalajs.LinkingInfo]({{ site.production_url }}/api/scalajs-library/0.6.6/#scala.scalajs.LinkingInfo$)."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@sjrd
Copy link
Member Author

sjrd commented Jan 25, 2016

Updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really how one writes fiddle?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of fiddle says "Scala-Js-Fiddle"...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its HTML title says that, but the landing page says "Scala.jsFiddle": http://www.scala-js-fiddle.com/gist/9443f8e0ecc68d1058ad/LandingPage.scala

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it into a link, so at least it doesn't have the "is there a dot/comma/space?" problem

@gzm0
Copy link
Contributor

gzm0 commented Jan 25, 2016

LGTM otherwise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the word "entire". I think We have ported the JUnit API to Scala.js, ... should be good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@nicolasstucki
Copy link
Contributor

That is all, otherwise LGTM.

@sjrd
Copy link
Member Author

sjrd commented Jan 25, 2016

Updated for the "entire". In doubt, I haven't changed the fiddle name.

nicolasstucki added a commit that referenced this pull request Jan 25, 2016
Update the documentation for 0.6.6 and announce it.
@nicolasstucki nicolasstucki merged commit e1abd27 into scala-js:master Jan 25, 2016
@sjrd sjrd deleted the scalajs-0.6.6 branch January 25, 2016 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants