-
Notifications
You must be signed in to change notification settings - Fork 148
Update the documentation for 0.6.6 and announce it. #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review by @gzm0, @nicolasstucki and anyone else who wants to. |
4df047a to
a9fa5cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads a bit hard. How about:
"The new methods isDevelopmentMode and isProductionMode allow you to query in your code whether you are running in a Development build or a Production build (for all ...). The methods are located in [scala.scalajs.LinkingInfo]({{ site.production_url }}/api/scalajs-library/0.6.6/#scala.scalajs.LinkingInfo$)."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
|
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that really how one writes fiddle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of fiddle says "Scala-Js-Fiddle"...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its HTML title says that, but the landing page says "Scala.jsFiddle": http://www.scala-js-fiddle.com/gist/9443f8e0ecc68d1058ad/LandingPage.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it into a link, so at least it doesn't have the "is there a dot/comma/space?" problem
|
LGTM otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the word "entire". I think We have ported the JUnit API to Scala.js, ... should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
|
That is all, otherwise LGTM. |
|
Updated for the "entire". In doubt, I haven't changed the fiddle name. |
Update the documentation for 0.6.6 and announce it.
Scaladoc for the library of 0.6.6 available at http://www.scala-js.org/api/scalajs-library/0.6.6/#scala.scalajs.js.package