Moved badge generator to Libraries main page #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_includes/badge-generator.html
Outdated
There was a problem hiding this comment.
The two URLs should include www., as in https://www.scala-js.org/...
The non-www URLs http-redirect to http://www.scala-js.org/ (without the s of https).
There was a problem hiding this comment.
In fact, it would be better to use {{ site.production_url }}/assets/...
There was a problem hiding this comment.
Yeah, adding www is good. But production_url doesn't give the HTTPS we want, so that there are never any security conflicts in sites using the badges. Better to hardcode the HTTPS there in this case.
|
That's all. |
|
LGTM |
sjrd
added a commit
that referenced
this pull request
Jan 28, 2016
Moved badge generator to Libraries main page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.