Fix #1870: Add js.constructorOf[JSClass] to retrieve its constructor. #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @nicolasstucki |
|
Refer to this link for build results (access rights to CI server needed): https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2147/ |
sjrd
force-pushed
the
js-constructor-of
branch
from
5b67193 to
344a260
Compare
…tructor. The method `js.constructorOf[JSClass]` returns the JavaScript constructor function for the class `JSClass`. The latter must be a class (not trait nor object) extending js.Any. It may be a native JS class or a Scala.js-defined JS class. The restrictions on what types can be used are enforced at compile-time.
|
LGTM |
|
Refer to this link for build results (access rights to CI server needed): https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2148/ |
sjrd
added a commit
that referenced
this pull request
Aug 27, 2015
Fix #1870: Add js.constructorOf[JSClass] to retrieve its constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
js.constructorOf[JSClass]returns the JavaScript constructor function for the classJSClass. The latter must be a class (not trait nor object) extending js.Any. It may be a native JS class or a Scala.js-defined JS class. The restrictions on what types can be used are enforced at compile-time.