Skip to content

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Aug 28, 2015

The announcement is scheduled for Monday 31st morning CEST, assuming everything goes well with the release process.

@sjrd
Copy link
Member Author

sjrd commented Aug 28, 2015

Review by everyone ;)
Pinging the usual suspects: @nicolasstucki @gzm0 @lihaoyi
as well as people who have expressed manifest interest/have already tried Scala.js-defined JS classes: @jducoeur @mysticfall @chandu0101 @russpowers (feel free to Unsubscribe on the right if you don't want to follow this)

@lihaoyi
Copy link
Contributor

lihaoyi commented Aug 28, 2015

Looks good to me. So many new things =D I guess after this we'll go and annotate all of scala-js-dom and other facade libraries with @js.native?

The visual asymmetry between @js.native and @ScalaJSDefined bugs me somewhat, but I guess it's no big deal.

@sjrd
Copy link
Member Author

sjrd commented Aug 28, 2015

I guess after this we'll go and annotate all of scala-js-dom and other facade libraries with @js.native?

Yes ^^

The visual asymmetry between @js.native and @ScalaJSDefined bugs me somewhat, but I guess it's no big deal.

It is not nice, but remember that @ScalaJSDefined will eventually completely disappear.

@sjrd sjrd force-pushed the announce-0.6.5 branch 2 times, most recently from 3df4ef0 to f82a5f6 Compare August 28, 2015 20:43
@jducoeur
Copy link
Contributor

LGTM, and looking forward to it -- should seriously improve facade development...

@russpowers
Copy link

Looks good, thanks for this really useful release!

@chandu0101
Copy link
Contributor

👍 👏 👏 🎆

thanks for this really useful release!
should seriously improve facade development...

+100 :)

Anonymous classes and object literals

I missed this before , a handy one definitely . Out of curiosity we must implement all fields right ? ,not a replacer for companion objects/builder .. ?

@chandu0101
Copy link
Contributor

scala-js/scala-js#1883 is missing

@sjrd
Copy link
Member Author

sjrd commented Aug 29, 2015

Out of curiosity we must implement all fields right ? ,not a replacer for companion objects/builder .. ?

Yes, since Scala.js-defined JS traits cannot have concrete members, the Scala type system will basically force you to implement all advertised members. So for typical options object, that means you have to implement default values as well.

Note that you could provide an AbstractOptions inheriting from your Options, with concrete implementations for optional values (with = js.undefined). Then you can extend that one instead in your object literal, and then you don't have to provide all values anymore :-)

scala-js/scala-js#1883 is missing

Indeed, thanks. And I also forgot scala-js/scala-js#1818

@sjrd
Copy link
Member Author

sjrd commented Aug 29, 2015

Artifacts published on Maven Central. ScalaDocs and CLI downloads up on the webserver.

@ngbinh
Copy link

ngbinh commented Aug 29, 2015

👯 🌹 try it out soon

@sjrd
Copy link
Member Author

sjrd commented Aug 29, 2015

Updated with references to js.constructorOf[C] (scala-js/scala-js#1883) and the bug scala-js/scala-js#1818.

@sjrd sjrd force-pushed the announce-0.6.5 branch 3 times, most recently from e5a4667 to 0ddccd6 Compare August 30, 2015 10:11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider putting "in Scala.js" at the end of the phrase.

@gzm0
Copy link
Contributor

gzm0 commented Aug 31, 2015

That's all. The SJS defined classes section is a bit minimalistic in some spots, but it's probably better to leave it until someone asks anyways :)

@sjrd
Copy link
Member Author

sjrd commented Aug 31, 2015

OK I will make the changes before merging in 2/3 hours.

@sjrd
Copy link
Member Author

sjrd commented Aug 31, 2015

Updated.

sjrd added a commit that referenced this pull request Aug 31, 2015
Update the docs for 0.6.5 and announce its release.
@sjrd sjrd merged commit fa36a99 into scala-js:master Aug 31, 2015
@sjrd sjrd deleted the announce-0.6.5 branch August 31, 2015 07:32
mathieuleclaire pushed a commit to mathieuleclaire/scala-js-website that referenced this pull request Sep 3, 2015
Update the docs for 0.6.5 and announce its release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants