Re-work recent dottiness in java.io.RandomAccessTest #4503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeTibbert
changed the title
LeeTibbert
referenced
this pull request
Oct 3, 2025
* Update run-jdk-compliance-tests workflow to JDK 25 LTS * Touch-up tests for JDK 25
WojciechMazur
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kitbellew kindly noticed that changes to
java.io.RandomAccessTestTestcanNotOpenReadOnlyFileForWritedid not make sense. Those changes were introduced in PR #4474.
Re-work that dottiness to:
make it clear that the change is required for Windows.
Linux & macOS do not require the change in file protection.
Making the protection change explicit makes the logic easier
to follow without knowing specific os pecularities.
restore the prior and correct try/finally block structure.
My thanks to kitbellew for the discovery & report.