Skip to content

Commit 303188c

Browse files
bishaboshasjrd
andauthored
Apply suggestions from code review
Add suggestions Co-Authored-By: Sébastien Doeraene <sjrdoeraene@gmail.com>
1 parent 30154a7 commit 303188c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

_sips/minutes/2020-03-13-sip-minutes.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ Martin presented `@main` functions:
7777
- Initialisation code in object can cause problems for thread safety.
7878
- Because we have top level definitions, it makes perfect sense to allow program entrypoint to be method at the top level.
7979
- What should the program be called? We use the `@main` annotation to capture the method name and create a wrapper class of the same name in the package containing the method.
80-
- Also provide minimal commandline argument processing to map directly to method parameters, using the `FromDigits` type class.
80+
- Also provide minimal commandline argument processing to map directly to method parameters, using the `FromString` type class.
8181

8282
#### Concerns with Commandline Argument Processing
8383

@@ -111,7 +111,7 @@ Adriaan:
111111
- Is `FromString` too general to use for CLI processing, it could make evolution harder if people use it for other cases.
112112
- Lots of options for the problem of structuring unstructured data, such as `:` separated lists for class paths. A general type class is too basic for this situation.
113113
- However, it is easier to make a local specific `FromString` just for CLI than in haskell where you must consider global importance.
114-
- Agrees that whatever argument processing should be able to map directly to method arguments, but something more specialised than `FromDigits` should be used.
114+
- Agrees that whatever argument processing should be able to map directly to method arguments, but something more specialised than `FromString` should be used.
115115
- Alternatively the current proposal could go ahead, but removing hooks for extension in the StdLib.
116116

117117
Martin, addressing these concerns:
@@ -157,7 +157,7 @@ Guillaume:
157157

158158
#### Summary
159159

160-
The main concerns with the proposal are the interactions between the intended use case and the pressure it imposes on the Standard Library. If it is only intended for very simple ordered arguments then perhaps a pluggable `FromDigits` type class is too simple to include in the standard library. If the language should support more complicated processing, then `FromDigits` is too basic to be pluggable.
160+
The main concerns with the proposal are the interactions between the intended use case and the pressure it imposes on the Standard Library. If it is only intended for very simple ordered arguments then perhaps a pluggable `FromString` type class is too simple to include in the standard library. If the language should support more complicated processing, then `FromString` is too basic to be pluggable.
161161

162162
In a straw poll the present members of the committee were in favour of having the `@main` annotation for program entry points, but perhaps someone could come up with a proposal for a more sophisticated processing solution.
163163

@@ -177,7 +177,7 @@ Jamie:
177177

178178
Sébastien:
179179

180-
- In Scala it is rare to have concrete expected type, e.g. the left hand side of an operation.
180+
- In Scala we often lack a concrete expected type, e.g. the left hand side of an operation.
181181
- How well does this scale
182182
- Concerns for loss of precision, e.g. different behaviour of adding different numeric types etc.
183183

0 commit comments

Comments
 (0)