Skip to content

Elaborate Regular Expression Patterns #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SethTisue merged 2 commits into from
Aug 3, 2022
Merged

Elaborate Regular Expression Patterns #2462

SethTisue merged 2 commits into from
Aug 3, 2022

Conversation

@byyue
Copy link
Contributor

@byyue byyue commented Jul 6, 2022

Close #2452.

image

julienrf
julienrf reviewed Jul 6, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help @byyue! I have a few comments.

@byyue @julienrf
Make the description clearer
c294421 
Co-authored-by: Julien Richard-Foy <julien@richard-foy.fr>
@SethTisue SethTisue merged commit 7396cca into scala:main Aug 3, 2022
@SethTisue
Copy link
Member

SethTisue commented Aug 3, 2022

thank you!

@byyue byyue deleted the dev-2452 branch August 5, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julienrf julienrf julienrf approved these changes

@Philippus Philippus Philippus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

To elaborate Regular Expression Patterns

4 participants

@byyue @SethTisue @julienrf @Philippus