Skip to content

Conversation

@eugene70
Copy link
Contributor

No description provided.

@eugene70
Copy link
Contributor Author

need to rebuild, how?

@eugene70
Copy link
Contributor Author

@byeonggukgong, @eed3si9n, please take a look.

@eed3si9n
Copy link
Member

I'd love to review, but I can't myself. Maybe find someone who can? /cc @yoohaemin

@byeonggukgong
Copy link
Member

@eugene70 @eed3si9n I'll review it this weekend, if I can.

@SethTisue
Copy link
Member

@byeonggukgong ping

@byeonggukgong
Copy link
Member

@SethTisue Ooops, I was so busy lately that I forgot. Thanks for the ping. Maybe this weekend I can review this translated documents. :)

Recently, the English document has been changed a bit.
Copy link
Member

@byeonggukgong byeonggukgong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished review this changes. :)

@eugene70
Copy link
Contributor Author

eugene70 commented Oct 2, 2019

Take a look again.

@eed3si9n
Copy link
Member

eed3si9n commented Oct 2, 2019

I am happy to merge this as is assuming you've addressed the review comments. We can always come back and fix things up later.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eed3si9n eed3si9n merged commit 170b81e into scala:master Oct 2, 2019
@eugene70
Copy link
Contributor Author

eugene70 commented Oct 2, 2019

Thanks @eed3si9n & @byeonggukgong !
I will go on.

@eugene70 eugene70 deleted the fix-tour branch October 2, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants