Fix outdated sample code for querying types in Symbols doc #1709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other parts of this have the updated `___Name()` syntax. These examples were probably just missed.
nogurenn
changed the title
SethTisue
approved these changes
Jun 11, 2020
Contributor
Author
|
I missed this part. What return type do I use? I'll add it to this PR. @ import scala.language.experimental.macros
import scala.language.experimental.macros
@ def impl(c: scala.reflect.macros.Context) = c.Expr[Unit](c.parse("println(2)"))
defined function impl
@ def test = macro impl
cmd102.sc:1: macro defs must have explicitly specified return types
def test = macro impl
^
Compilation Failed |
Member
|
[...]
scala 2.13.2> def test: Unit = macro impl
def test: Unit
scala 2.13.2> test
2 |
Contributor
Author
|
I missed that big time. Sorry :( |
Based on deprecation doc of `stringToTermName` and `stringToTypeName`, people should avoid using these implicit conversions in particular.
`isOverride` is now private according to the 2.13 source. Changing the example to `isFinal` instead.
Member
|
excellent, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other parts of this have the updated
___Name()syntax. These examples were probably just missed.