Modify explanation of example #1945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The failing build is not related to this PR, but is #1953 This looks good to me. I think the original intent of the text was to echo the "everything is an object" maxim. I don't think that matters. Your wording sounds clearer than it was before in my eye. I don't know how things are able to sound in my eye, but it is what it is. |
Contributor
Author
|
Thanks for the review! That makes sense re the maxim, and I like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this example is meant to show that all objects in Scala are of type
Any.I am new to Scala, and may have misinterpreted this, but in any case I think the existing suggestion that the example shows that numerous types "are all objects just like every other object" is difficult to interpret having read only the preceding introductory tour docs.