Update overview.md #927
Merged
Update overview.md #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method Type.delaration has been depricated in Scala 2.11.0 in favour of Type.decls.
Member
|
good catch. thank you! |
marconilanna
reviewed
Dec 5, 2017
| constructor of class `Person`. | ||
|
|
||
| scala> val ctor = ru.typeOf[Person].declaration(ru.nme.CONSTRUCTOR).asMethod | ||
| scala> val ctor = ru.typeOf[Person].decls(ru.nme.CONSTRUCTOR).asMethod |
Contributor
There was a problem hiding this comment.
@SethTisue This PR introduced a bug, replacing declaration (singular) with decls (plural) here and on line 174 below. A fix is part of #935
marconilanna
reviewed
Dec 5, 2017
| access member `shipped`. | ||
|
|
||
| scala> val shippingTermSymb = ru.typeOf[Purchase].declaration(ru.TermName("shipped")).asTerm | ||
| scala> val shippingTermSymb = ru.typeOf[Purchase].decls(ru.TermName("shipped")).asTerm |
Contributor
There was a problem hiding this comment.
The code as is (ru.typeOf[Purchase].decls(ru.TermName("shipped")).asTerm) produces the following error: "reflect.runtime.universe.MemberScope does not take parameters"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method Type.delaration has been depricated in Scala 2.11.0 in favour of Type.decls.