Fix NoClassDefFoundError when using old zinc version [ci: last-only]

[Friendseeker]

c.c. #10905 (comment)

We explicitly catch the exception, as in

scala/src/sbt-bridge/scala/tools/xsbt/CompilerBridge.scala

Lines 158 to 160 in 1f34012

	lazy val callback2 =
	try callback.asInstanceOf[AnalysisCallback2]
	catch { case _: NoClassDefFoundError => null}

@SethTisue

[SethTisue]

(labeled "internal" since the problem it addresses never appeared in a release)

[SethTisue]

Is there some way we can prevent this from recurring in the future?

("this" = accidentally depending on some too-new API)

[Friendseeker]

Is there some way we can prevent this from recurring in the future?

("this" = accidentally depending on some too-new API)

Maybe we can add exactly one build to scala community builds with an old sbt version? So every other builds in community builds run with latest sbt version but the one build does not.

[lrytz]

Thank you!

[SethTisue]

I'll give the question of avoiding recurrence some thought in the new year.

[SethTisue]

This doesn't seem to fix the problem in the Scala Native repo, I still get

[error] ## Exception when compiling 65 sources to /Users/tisue/scala-native/nscplugin/.2.13/target/scala-2.13/classes
[error] java.lang.NoClassDefFoundError: xsbti/AnalysisCallback3
[error] scala.tools.xsbt.ZincCompiler.callback3Opt$lzycompute(CallbackGlobal.scala:90)
[error] scala.tools.xsbt.ZincCompiler.callback3Opt(CallbackGlobal.scala:90)
[error] scala.tools.xsbt.ZincCompiler.getSourceFile(CallbackGlobal.scala:93)
[error] scala.tools.nsc.Global$Run.$anonfun$compileFiles$1(Global.scala:1651)
[error] scala.tools.nsc.Global$Run.compileFiles(Global.scala:1651)
[error] scala.tools.xsbt.CachedCompiler0.run(CompilerBridge.scala:176)
[error] scala.tools.xsbt.CachedCompiler0.run(CompilerBridge.scala:139)

this is from a clean checkout of scala-native with (on JDK 17) set ThisBuild / resolvers += "int" at "https://scala-ci.typesafe.com/artifactory/scala-integration/" then ++2.13.16-bin-1f34012! then Test/compile

[SethTisue]

Oh, I bet it's because Try only catches scala.util.control.NonFatal throwables...! But NoClassDefFoundError is an Error and those are considered fatal

[Friendseeker]

Oh, I bet it's because Try only catches scala.util.control.NonFatal throwables...! But NoClassDefFoundError is an Error and those are considered fatal

Thanks for the observation! Making another PR right now.

[SethTisue]

I've just submitted #10966

[SethTisue]

I've verified that #10966 fixes the problem as originally reported in the Scala Native repo.