Backport "Use upper bound of abstract types in exhaustivity checking" to 3.3 LTS #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes scala#23620, scala#24246 If the upper bound of an abstract type is not `sealed` but is effectively sealed, it is not handled correctly, since classSym could return a type that is not `sealed` (Object in the issue above). If the type were not abstract, it would pass the logic that checks whether it is an Or, And, etc., and would be handled properly. This PR makes exhaustivity checking use the upper bound of abstract types that are effectively sealed. --------- Co-authored-by: Zieliński Patryk <75637004+zielinsky@users.noreply.github.com>
closes scala#23620, scala#24246 If the upper bound of an abstract type is not `sealed` but is effectively sealed, it is not handled correctly, since classSym could return a type that is not `sealed` (Object in the issue above). If the type were not abstract, it would pass the logic that checks whether it is an Or, And, etc., and would be handled properly. This PR makes exhaustivity checking use the upper bound of abstract types that are effectively sealed. --------- Co-authored-by: Zieliński Patryk <75637004+zielinsky@users.noreply.github.com> [Cherry-picked 520668f][modified]
Author
|
No regressions detected in the community build up to backport-lts-3.3-24277. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports scala#23909 to the 3.3.7.
PR submitted by the release tooling.
[skip ci]