Skip to content

bugfix: Fix possible SuspendException thrown when using macros #24174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2025
Merged

bugfix: Fix possible SuspendException thrown when using macros #24174

merged 2 commits into from
Oct 15, 2025
+22 −7

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Oct 13, 2025

@tgodzik tgodzik requested a review from zielinsky October 13, 2025 07:30
rochala
rochala reviewed Oct 13, 2025
View reviewed changes
zielinsky
zielinsky approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@zielinsky zielinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zielinsky zielinsky merged commit 96aff06 into scala:main Oct 15, 2025
51 checks passed
@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 22, 2025
@WojciechMazur WojciechMazur mentioned this pull request Oct 22, 2025
Merged
WojciechMazur added a commit that referenced this pull request Oct 22, 2025
@WojciechMazur
Backport "bugfix: Fix possible SuspendException thrown when using mac…
bb9ff72 
…ros" to 3.7.4 (#24222)

Backports #24174 to the 3.7.4.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added this to the 3.7.4 milestone Oct 22, 2025
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rochala rochala rochala left review comments

@zielinsky zielinsky zielinsky approved these changes

Assignees

No one assigned

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.7.4

Development

Successfully merging this pull request may close these issues.

Completions stop working dotty.tools.dotc.CompilationUnit$SuspendException

4 participants

@tgodzik @rochala @zielinsky @WojciechMazur