Skip to content

Conversation

@hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Oct 23, 2025

This is the first step into removing all the warnings from the stdlib. It migrates the following:

  • remove all [this] in private[this] and protected[this]
  • All wildcards change from _ to ?
  • Change infix cola of non-infix methods to the dot notation
  • Add using keyword when needed
  • Changes the location of classes to reflect their package hierarchy (61fb86e)
  • Rewrite non-local returns (fcaa351)

@hamzaremmal hamzaremmal marked this pull request as ready for review October 23, 2025 21:07
@hamzaremmal hamzaremmal requested a review from a team as a code owner October 23, 2025 21:07
@hamzaremmal hamzaremmal enabled auto-merge October 23, 2025 21:08
Copy link
Contributor

@WojciechMazur WojciechMazur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The change to private[this] / protected[this] fields might affect unsafe access to fields via reflection, but that's not an issue, since it's, well, private (AFAIR with private[this] we were accessing field directly, not using the accessor)

I haven't seen any cases of A with B <:< C, these are tricky since the correct rewrite is (A & B <:< C), but compiler rewrites might insert A & B <:< C which is interpreted as
A & (B <:< C). The one trickier case in ExecutionContext is correctly handled.

@hamzaremmal hamzaremmal merged commit 84d54a4 into scala:main Oct 23, 2025
51 checks passed
@hamzaremmal hamzaremmal deleted the less-warnings branch October 23, 2025 22:45
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Oct 28, 2025
hamzaremmal added a commit that referenced this pull request Oct 29, 2025
Pretty much self explanatory. For the vulpix, we recover the old
behavior of removing the progress bar.
For the warnings, a PR was already merged #24240 and more to come.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants