Skip to content

Conversation

@WojciechMazur
Copy link
Contributor

Reverts #24227 from Scala 3.7.4-RC3 due to #24266 and other regressions, that are unlikely to be fixed in a required time window (we want to release 3.7.4 stable next week, which leaves at most 1 day for developing and testing the fixes).
Would be kept in the 3.8 series

@som-snytt
Copy link
Contributor

Note that llm4s build OOMs trying to Vprint:inlining, but one would not revert -Vprint on that basis.

@som-snytt
Copy link
Contributor

We're still at 0.5 days, simple PRs are available for review, if desired.

@Gedochao
Copy link
Contributor

@WojciechMazur I guess the alternative would be to back port the 3 fixes from last night (they still need review):

@som-snytt
Copy link
Contributor

An argument in favor of reverting is that people will be eager to upgrade to 3.8. I think the PRs are an improvement, and small in scope, but it's also nice to have time for feedback. My only sense of urgency is that it's hard to get PRs merged, so that it's better not to step backward; but timing is everything.

@WojciechMazur
Copy link
Contributor Author

Let's test these 3 branches backported to release-3.7.4 against the OpenCB. If there would be no new issues, let's merged them as it's also fixing the regressions introduced in 3.8.0, otherwise let's revert and delay until 3.8.

@WojciechMazur
Copy link
Contributor Author

We'd use the backported fixes instead of this revert - all the known issues are fixed, no performance issues visible, no new regressions, scala-cli passes the build (when using main 3 subprojects are failing but it's the same when using 3.7.3 or 3.7.4-RC3)
@som-snytt Thank you for your heroic work!

@WojciechMazur WojciechMazur deleted the revert-24227-release-3.7.4_backport-24043 branch October 28, 2025 21:11
@som-snytt
Copy link
Contributor

@WojciechMazur Thanks for taking a chance. I'm available all weekend for follow-ups. Probably the world series is over by then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants