fix the dependencies of the bootstrapped stdlib #24379
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
Nov 12, 2025
| // because we allow cross-compilation. | ||
| versionScheme := Some("always"), | ||
| crossPaths := false, | ||
| crossVersion := CrossVersion.disabled, |
Member
Author
There was a problem hiding this comment.
@sjrd seems we have broken the artifact name on October 8th when we added the DottyJSPlugin to this project. This here fixes it but is it the correct way?
See the nightly releases: https://repo.scala-lang.org/ui/repos/tree/General/local-maven-nightlies/org/scala-js/scalajs-scalalib_2.13_sjs1_3/3.8.0-RC1-bin-20251008-6194563-NIGHTLY.
…-language-server` sbt doesn't evict a library dependency if it has the same dependency as a project
…js1_3` This broke when we added the a dependency to the `DottyJSPlugin`
hamzaremmal
force-pushed
the
stdlib-bootstrapped-deps
branch
from
7d82fbf to
e1953d8
Compare
Gedochao
approved these changes
Nov 12, 2025
Gedochao
added
the
backport:nominated
WojciechMazur
added
backport:accepted
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we used to rely on the presence of the
scala-library:2.13.xin the classpath to copy the binaries. This was not the case for a long time now and we can correctly not depend on it in the bootstrapped library.