cleanup the build and remove all the old stuff #24449
Conversation
hamzaremmal
force-pushed
the
cleanup-build
branch
from
cad66b9 to
82fd644
Compare
| // Used to run binaries similar to ./bin/scala script | ||
| val scala = inputKey[Unit]("run compiled binary using the correct classpath, or the user supplied classpath") | ||
|
|
||
| val repl = taskKey[Unit]("spawns a repl with the correct classpath") |
There was a problem hiding this comment.
Do we have some replacements for these tasks or maybe these were broken and unusable already?
For repl that likely just a console, what about the others?
There was a problem hiding this comment.
You just have to run run in the scala3-repl :)
There was a problem hiding this comment.
Yes, I've refered to scala, buildQuick, genDocs and packageAll
There was a problem hiding this comment.
they were removed as they are/were not relevant anymore. For genDocs, scaladoc is a mess and that is the reason why we still have scaladoc and scaladoc-new in the PR. So if a replacement is needed, it will be added when scaladoc is cleaner.
| scriptedLaunchOpts ++= Seq( | ||
| s"-Dplugin.scalaVersion=${dottyVersion}", | ||
| s"-Dplugin.scala2Version=${stdlibVersion(Bootstrapped)}", | ||
| s"-Dplugin.scala2Version=2.13.16", |
There was a problem hiding this comment.
We'll forget to update this. There is also 1 more in ScalaLibraryPlugin, maybe let's use that one
There was a problem hiding this comment.
Yea, there are two variables, not just one. It will be in the refactoring.
2 participants
This is the second step in the build changes. We previously introduced new projects for all the new artifacts. Now we remove all of the old ones (except scaladoc). This step is just removing, making the build easier to understand and avoid duplication will be in the upcoming PR (third step).