update StringBuilder.toString to have an empty parameter list
#24452
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note that this still doesn't solve the root issue but rather closes that very specific issue. |
hamzaremmal
changed the title
StringBuilder.toString to have an empty parameter list
Member
Author
|
Closed in favor of the more general PR (#24461) |
hamzaremmal
added a commit
that referenced
this pull request
Nov 20, 2025
To preserve the same source compatibility, we mark `toString` and `hashCode` as methods with empty parameter lists in all the inherited files from Scala 2. Note that I checked for other java defined methods that would qualify for this change but I couldn't find any (reviewer should double check too since we cannot fix this after 3.8.0). Closes #19616 Supersedes #24452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is both source compatible and binary compatible. This might only break macros but they should be able to call
ensureAppliednow in3.8.0(#24160).This used to be working in
3.7.4.Closes #19616