Skip to content

fix: make scala3-nonbootstrapped the default project #24455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
+2 −2
Merged

fix: make scala3-nonbootstrapped the default project #24455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@ object Build {
// ================================= NON-BOOTSTRAPPED PROJECTS ==================================
// ==============================================================================================

lazy val `scala3-nonbootstrapped` = project
lazy val `scala3-nonbootstrapped` = project.in(file("."))
Copy link
Member

@mbovel mbovel Nov 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, compiling scala3-nonbootstrapped now also tries to compile files in the root directory. We don't want that, do we?

Reproduction:

/scala3$ echo 'def f: Int = "Hello"' > test.scala
/scala3$ sbtn compile
[info] entering *experimental* thin client - BEEP WHIRR
[info] terminate the server with `shutdown`
> compile
[info] compiling 1 Scala source to /scala3/target/scala3-nonbootstrapped/scala-2.12/classes ...
[error] /scala3/test.scala:1:1: expected class or object definition
[error] def f: Int = "Hello"
[error] ^
[error] one error found
[info] compiling 4 Java sources to /scala3/sbt-bridge/target/scala3-sbt-bridge-nonbootstrapped/classes ...
[error] Total time: 2 s, completed Nov 17, 2025, 1:07:58 PM

.aggregate(`scala3-interfaces`, `scala3-library-nonbootstrapped` , `scala-library-nonbootstrapped`,
`tasty-core-nonbootstrapped`, `scala3-compiler-nonbootstrapped`, `scala3-sbt-bridge-nonbootstrapped`)
.settings(
Expand Down Expand Up @@ -815,7 +815,7 @@ object Build {
// Nothing to be published by this project
publish / skip := true,
// Project specific target folder. sbt doesn't like having two projects using the same target folder
target := target.value / "scala3-bootstrapped",
target := (ThisBuild / baseDirectory).value / "target" / "scala3-bootstrapped",
scalac := Def.inputTaskDyn {
val log = streams.value.log
val externalDeps = (`scala3-compiler-bootstrapped-new` / Runtime / externalDependencyClasspath).value
Expand Down
Loading