Skip to content

Remove unsafeNulls hack for stdlib migration #24464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

Remove unsafeNulls hack for stdlib migration #24464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions library/src/scala/IArray.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,14 +346,13 @@ object IArray:
mapNull(arr, ArraySeq.unsafeWrapArray(arr))

/** Conversion from IArray to immutable.ArraySeq */
import scala.language.unsafeNulls // TODO!!! only for stdlib migration!
implicit def wrapRefArray[T <: AnyRef | Null](arr: IArray[T]): ArraySeq.ofRef[T] =
// Since the JVM thinks arrays are covariant, one 0-length Array[AnyRef | Null]
// is as good as another for all T <: AnyRef | Null. Instead of creating 100,000,000
// unique ones by way of this implicit, let's share one.
mapNull(arr,
if (arr.length == 0) ArraySeq.empty[AnyRef | Null].asInstanceOf[ArraySeq.ofRef[T]]
else ArraySeq.ofRef[AnyRef](arr.asInstanceOf[Array[AnyRef]]).asInstanceOf[ArraySeq.ofRef[T]]
else ArraySeq.ofRef(arr.asInstanceOf[Array[T]])
)

/** Conversion from IArray to immutable.ArraySeq */
Expand Down
Loading