Ignore selection prototypes when typing type applications #24489
+32
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore selection prototypes at first when typing type applications. If we need them later for overloading disambiguation, reveal the ignored type. The reason for doing this is that a selection might come from an extension method, and in this case we should not require the selected name as a member of the result. This change breaks one test (overloading-specifity-2.scala) that explicitly tested that we don't consult implicit arguments for disambiguation since the expected type was a selection that already determined the outcome. This is logic no longer holds. We have to see whether this change breaks any code in practice. Fixes scala#23773
Contributor
Author
|
@hamzaremmal I am surprised to not see community build tasks in the task list. Where are they? |
Member
|
They are there, they just kick in later. |
Member
|
@WojciechMazur can we have an Open CB run on this PR? Thanks. |
hamzaremmal
added
the
backport:nominated
Contributor
|
Sure, I'll schedule the build as soon as I'll fix some infra problems |
Contributor
Author
|
This should be backported to 3.8.0 if it works but not to 3.3 since it involves a change in behavior. |
Member
Yes, the label is for 3.8.0, not 3.3.x |
hamzaremmal
reviewed
Nov 20, 2025
Member
hamzaremmal
left a comment
hamzaremmal
left a comment
There was a problem hiding this comment.
LGTM but I'll wait for the Open CB run result before approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore selection prototypes at first when typing type applications. If we need them later for overloading disambiguation, reveal the ignored type.
The reason for doing this is that a selection might come from an extension method, and in this case we should not require the selected name as a member of the result.
This change breaks one test (overloading-specifity-2.scala) that explicitly tested that we don't consult implicit arguments for disambiguation since the expected type was a selection that already determined the outcome. This logic no longer holds. We have to see whether this change breaks any code in practice.
Fixes #23773