Don't absolutize sources outside of the sourceroot in TASTy #24491
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With inlining and standard library patching, it's inevitable that, when writing TASTy files, we'll encounter sources outside the sourceroot. However, we shouldn't write those sources as absolute paths because that's non-reproducible and can cause determinism issues. Instead, we should write the paths as-is. While these sorts of paths aren't correct when written relatively, they weren't correct to begin with because they don't actually exist on the filesystem.
Contributor
|
Hey, all contributors are required to sign the Scala CLA (as indicated by the failure on the CI). |
hamzaremmal
requested changes
Nov 21, 2025
Member
hamzaremmal
left a comment
hamzaremmal
left a comment
There was a problem hiding this comment.
However, we shouldn't write those sources as absolute paths because that's non-reproducible and can cause determinism issues. Instead, we should write the paths as-is.
As well as privacy issues.
I'm not sure here what are all the usages of this method. I'll dig further and reply back here.
| path.iterator.asScala.mkString("/") | ||
| else | ||
| sourcePath.toString | ||
| jpath.toString |
Member
There was a problem hiding this comment.
The scaladoc says:
It returns the absolute path of `source` if it is not contained in `reference`.
By returning jpath instead of sourcePath when sourcePath.startsWith(refPath) == false breaks the contract in the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24212
With inlining and standard library patching, it's inevitable that, when writing TASTy files, we'll encounter sources outside the sourceroot. However, we shouldn't write those sources as absolute paths because that's non-reproducible and can cause determinism issues. Instead, we should write the paths as-is.
While these sorts of paths aren't correct when written relatively, they weren't correct to begin with because they don't actually exist on the filesystem.