Fix #476, restoreScopes should maintain companion links #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@smarter please review. |
Member
|
Otherwise, LGTM. |
DarkDimius
force-pushed
the
fix-restoreScopes
branch
from
6a472bf to
3c9fb03
Compare
Contributor
Author
|
additional checking in Ycheck somehow triggered StackOverflows in |
Triggers cycles in ExtensionMethods.
…much." The problem was due to cycles in ExtensionMethod themselves. This reverts commit 1ce894e.
DarkDimius
force-pushed
the
fix-restoreScopes
branch
3 times, most recently
from
4de0dd7 to
4efca0f
Compare
Member
|
Was the build failure transient or is something still wrong? |
Contributor
Author
Member
|
I think |
Contributor
Author
|
It would be if I would use created context to type the tree, as other modes influence type checking. |
DarkDimius
added a commit
that referenced
this pull request
Apr 20, 2015
Fix #476, restoreScopes should maintain companion links
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Jul 23, 2025
Backport "fix: simplify infer type for apply" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.