Forked ScalaRuntime and minimal classtags for arrays of value classes. #515
Conversation
|
@smarter please review. |
There was a problem hiding this comment.
Shouldn't it be a -Y option? It's a "compiler hacker" option and it's a bit dangerous since toggling it can break an API since it changes method signatures.
There was a problem hiding this comment.
I would actually be using it during my everyday development and would recommend others, because it simplifies debugging. So I'd not consider it as "compiler hacker" option.
Though I'm fine with it being either -X or -Y
restarting build. |
|
Otherwise LGTM |
There was a problem hiding this comment.
Value classes which are not case classes will not implement productPrefix, this should not be here.
There was a problem hiding this comment.
Scalac actually synthesizes toString on value classes, which is productPrefix + hex-encoded underlying value.
I belive that always implementing productPrefix does make sense.
Making actual value classes extend this prototypes serves two goals: - This is a basis for implementing arrays of value classes. - Having underlying final in those glasses makes all unbox methods monomorphic and final. - this decreases size of an empty case-class to 1/3 of previous size.
Decreases the size of companion of case value class to 1/8 of it's original size.
Works as Array[T] is erased to Object.
Unfortunately needed to sacrifice the immutability of inner field.
[error] /Users/dark/workspace/dotty/src/dotty/runtime/vc/VCPrototype.scala:10: overriding method clone in class VCArrayPrototype of type ()Object;
[error] method clone in class Object of type ()Object has weaker access privileges; it should be public;
[error] (Note that method clone in class VCArrayPrototype of type ()Object is abstract,
[error] and is therefore overridden by concrete method clone in class Object of type ()Object)
[error] abstract class VCArrayPrototype[T <: VCPrototype] extends Object with Cloneable {
It can be done with non-abstract rhs of method.
DarkDimius
force-pushed
the
classTags
branch
2 times, most recently
from
c7e7cc5 to
9d8a8de
Compare
Forked ScalaRuntime and minimal classtags for arrays of value classes.
Backport "Use result of lambda type of implicit in CheckUnused" to 3.3 LTS
3 participants
No description provided.