Skip to content

Remove rel="noopener noreferrer" from custom Docusaurus components #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Remove rel="noopener noreferrer" from custom Docusaurus components #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docusaurus.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ const config = {
// announcementBar: {
// id: 'new_version',
// content:
// // '<b>Announcing the release of ScalarDB X.X!🚀 For details on what\'s included in this new version, see the <a target="_self" rel="noopener noreferrer" href="/docs/latest/releases/release-notes?utm_source=docs-site&utm_medium=announcementbar">release notes</a>.<b>',
// // '<b>Announcing the release of ScalarDB X.X!🚀 For details on what\'s included in this new version, see the <a target="_self" href="/docs/latest/releases/release-notes?utm_source=docs-site&utm_medium=announcementbar">release notes</a>.<b>',
// backgroundColor: '#2673BB',
// textColor: '#FFFFFF',
// isCloseable: false,
Expand Down
1 change: 0 additions & 1 deletion src/components/NotificationBell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ const NotificationBell = ({ notifications }) => {
className={`notification-item ${!notification.read ? 'unread' : ''}`}
onClick={(e) => handleNotificationClick(notification, e)}
target={notification.isExternal ? '_blank' : '_self'}
rel={notification.isExternal ? 'noopener noreferrer' : undefined}
>
{notification.message}
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Support/SupportDropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ const SupportDropdownMenu: React.FC = () => {
const handleGitHubClick = (event: MouseEvent<HTMLAnchorElement>) => {
event.preventDefault();
if (githubIssueUrl !== "#") {
window.open(githubIssueUrl, "_blank", "noopener,noreferrer");
window.open(githubIssueUrl, "_blank");
} else {
console.error("GitHub issue URL is not set correctly.");
}
Expand Down
1 change: 0 additions & 1 deletion src/theme/JavadocLink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export default function JavadocLink({ packageName, path, className }) {
<a
href={`https://javadoc.io/static/com.scalar-labs/${packageName}/${docsClassName}/${path}/${className}.html`}
target="_blank"
rel="noopener noreferrer"
>
{className}
</a>
Expand Down