Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Conversation

@josh-wong
Copy link
Member

Description

This PR updates the PR template in this repository. The template is for helping to provide context for people who are involved with PRs and for future reference.

Related issues and/or PRs

N/A

Changes made

Revised the contents of the existing pull request template.

How these changes were tested

Checked that this PR template looks as expected in GitHub.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@josh-wong josh-wong added the documentation Improvements or additions to documentation label Sep 25, 2023
@josh-wong josh-wong self-assigned this Sep 25, 2023
Copy link
Collaborator

@choplin choplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

[skip ci]

Add `Checklist` description, and revise the `Related issues and/or PRs` description since the previous description might conflict with how GitHub handles PR linking.

Ref: scalar-labs/scalardb#1114
@josh-wong josh-wong removed the request for review from feeblefakie September 29, 2023 02:53
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@josh-wong josh-wong merged commit f61d808 into main Oct 2, 2023
@josh-wong josh-wong deleted the update-pr-template branch October 2, 2023 08:18
@brfrn169
Copy link
Collaborator

brfrn169 commented Oct 2, 2023

@reddikih (CC: @feeblefakie) This is not related to this PR directly, but should we also need to merge release notes of this repository to the ScalarDB release nodes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants