Skip to content

Add databases to ScalarDB Sample #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2024
Merged

Add databases to ScalarDB Sample #65

merged 1 commit into from
Jul 29, 2024

Conversation

@brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jul 23, 2024

Description

This PR adds some databases to ScalarDB Sample.

Related issues and/or PRs

N/A

Changes made

  • Added Oracle Database and SQL Server to database.properties and docker-compose.yml in ScalarDB Sample.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

komamitsu
komamitsu approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@brfrn169 brfrn169 force-pushed the add-databaeses-to-scalardb-sample branch from e1c3cbc to c0d5633 Compare July 24, 2024 06:02
josh-wong
josh-wong approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@josh-wong josh-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!🙇‍♂️

Torch3333
Torch3333 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Torch3333
Torch3333 reviewed Jul 25, 2024
View reviewed changes
feeblefakie
feeblefakie approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

kota2and3kan
kota2and3kan approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit df297ca into main Jul 29, 2024
@brfrn169 brfrn169 deleted the add-databaeses-to-scalardb-sample branch July 29, 2024 07:13
@brfrn169 brfrn169 mentioned this pull request Jul 29, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Torch3333 Torch3333 Torch3333 approved these changes

@komamitsu komamitsu komamitsu approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

@josh-wong josh-wong josh-wong approved these changes

@kota2and3kan kota2and3kan kota2and3kan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brfrn169 @komamitsu @feeblefakie @Torch3333 @josh-wong @kota2and3kan