-
Notifications
You must be signed in to change notification settings - Fork 7
Support ScalarDB Analytics 3.17 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the scalardb-analytics-sample project to support ScalarDB Analytics version 3.17.0, adapting to API changes in the CLI commands, configuration file formats, and property naming conventions introduced in this version.
- Docker images and Spark package upgraded from 3.16.2 to 3.17.0
- CLI command syntax updated to use new
--catalog,--data-source, and--provider-fileoptions - Data source configuration files simplified with flatter structure and type naming changes (
postgres→postgresql) - Server configuration property renamed from
db.urltodb.contact_points - Docker volume mounts adjusted to place
scalardb.propertiesin CLI container only - Spark Dockerfile download script improved with better variable usage
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docker-compose.yml | Updates Docker image versions to 3.17.0 and relocates scalardb.properties volume mount from server/spark to CLI container |
| config/scalardb-analytics-server.properties | Renames server database property from db.url to db.contact_points |
| config/spark-defaults.conf | Updates Spark package version to 3.17.0 |
| config/data-sources/postgres.json | Simplifies data source configuration structure and changes type from postgres to postgresql |
| config/data-sources/scalardb.json | Simplifies configuration to use flattened structure with configs field referencing properties file |
| README.md | Updates CLI command examples to use new syntax with --catalog, --data-source, and --provider-file options |
| docker/Dockerfile.spark | Improves download script with better variable naming and proper quoting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
brfrn169
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
Update scalardb-analytics-sample to support ScalarDB Analytics 3.17.
Related issues and/or PRs
N/A
Changes made
scalardb-analytics-server-without-licensing,scalardb-analytics-cliscalardb-analytics-spark-all-3.5_2.12data-source register--catalog,--data-source,--provider-filepostgres.json: Simplified structure, changed type frompostgrestopostgresqlscalardb.json: Simplified structure, useconfigswith file referencescalar.db.analytics.server.db.url→scalar.db.analytics.server.db.contact_pointsscalardb.propertiesmount from server/spark to CLI containerChecklist
Additional notes (optional)
This is a sample project update to align with ScalarDB Analytics 3.17 release.