Skip to content

Conversation

@choplin
Copy link
Contributor

@choplin choplin commented Nov 25, 2025

Description

Remove the scalardb-analytics-postgresql-sample directory as it is no longer needed.

Related issues and/or PRs

We already removes the related page from the documentation site in https://github.com/scalar-labs/docs-internal-scalardb/pull/1706

Changes made

  • Remove scalardb-analytics-postgresql-sample/ directory entirely

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

None

@choplin choplin marked this pull request as ready for review November 25, 2025 10:13
@choplin choplin self-assigned this Nov 25, 2025
Copilot finished reviewing on behalf of choplin November 25, 2025 10:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the obsolete scalardb-analytics-postgresql-sample directory from the repository. The removal is part of a cleanup effort, as the related documentation was already removed in a previous PR (scalar-labs/docs-internal-scalardb#1706). The change ensures consistency between the code samples and documentation.

  • Complete removal of the scalardb-analytics-postgresql-sample directory
  • No remaining references to this sample in the codebase or CI configuration
  • Aligns with documentation cleanup already completed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 406809e into main Nov 26, 2025
38 checks passed
@feeblefakie feeblefakie deleted the remove-scalardb-analytics-postgresql branch November 26, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants