Fix CosmosDB CI when running integration test with JDK11+ #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/ci.yaml
Torch3333
force-pushed
the
fix_cosmos_ci_for_jdk11+
branch
from
f4f0b30 to
5443770
Compare
Torch3333
changed the title
Torch3333
commented
Jun 19, 2024
| & ${env:JAVA_HOME}/bin/keytool.exe -keystore ${env:JAVA_HOME}/jre/lib/security/cacerts -storepass 'changeit' -list -alias cosmos_emulator | ||
| # Setting the keystore option differs between Java 8 and Java 11+ | ||
| if ( ${env:INT_TEST_JAVA_RUNTIME_VERSION} -eq '8' ) { | ||
| $keystore = "-keystore", "${env:JAVA_HOME}/jre/lib/security/cacerts" |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| $keystore = "-keystore", "${env:JAVA_HOME}/jre/lib/security/cacerts" | |
| $keystore = "-keystore ${env:JAVA_HOME}/jre/lib/security/cacerts" |
Writing this variable as a single string will not expand correctly in Powershell because it does not recognize -keystore as being an option for the keytool.exe command.
Instead, we need to separate the option from its value by storing it as an array in the $keystore variable.
It took me some time to figure it out 😓
feeblefakie
pushed a commit
that referenced
this pull request
Jun 19, 2024
feeblefakie
pushed a commit
that referenced
this pull request
Jun 19, 2024
feeblefakie
pushed a commit
that referenced
this pull request
Jun 19, 2024
feeblefakie
pushed a commit
that referenced
this pull request
Jun 19, 2024
feeblefakie
pushed a commit
that referenced
this pull request
Jun 19, 2024
feeblefakie
pushed a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CosmosDB CI fails when using JDK11+ as the runtime for the integration test. This is because the way to import TLS/SSL certificate in the Java "cacerts" keystore is not supported for JDK11+.
Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
N/A