Skip to content

Fix CosmosDB CI when running integration test with JDK11+ #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fix CosmosDB CI when running integration test with JDK11+ #1919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,14 @@ jobs:
Export-Certificate @params
certutil -encode $home/tmp-cert.cer $home/cosmosdbcert.cer
Remove-Item $home/tmp-cert.cer
& ${env:JAVA_HOME}/bin/keytool.exe -keystore ${env:JAVA_HOME}/jre/lib/security/cacerts -storepass 'changeit' -importcert -noprompt -alias cosmos_emulator -file $home/cosmosdbcert.cer
& ${env:JAVA_HOME}/bin/keytool.exe -keystore ${env:JAVA_HOME}/jre/lib/security/cacerts -storepass 'changeit' -list -alias cosmos_emulator
# Setting the keystore option differs between Java 8 and Java 11+
if ( ${env:INT_TEST_JAVA_RUNTIME_VERSION} -eq '8' ) {
$keystore = "-keystore", "${env:JAVA_HOME}/jre/lib/security/cacerts"
Copy link
Contributor Author

@Torch3333 Torch3333 Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$keystore = "-keystore", "${env:JAVA_HOME}/jre/lib/security/cacerts"
$keystore = "-keystore ${env:JAVA_HOME}/jre/lib/security/cacerts"

Writing this variable as a single string will not expand correctly in Powershell because it does not recognize -keystore as being an option for the keytool.exe command.
Instead, we need to separate the option from its value by storing it as an array in the $keystore variable.
It took me some time to figure it out 😓

} else {
$keystore = "-cacerts"
}
& ${env:JAVA_HOME}/bin/keytool.exe $keystore -storepass 'changeit' -importcert -noprompt -alias cosmos_emulator -file $home/cosmosdbcert.cer
& ${env:JAVA_HOME}/bin/keytool.exe $keystore -storepass 'changeit' -list -alias cosmos_emulator

- name: Setup and execute Gradle 'integrationTestCosmos' task
uses: gradle/gradle-build-action@v3
Expand Down