Add enum, constants for data loader #2386
Merged
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komamitsu
approved these changes
Dec 12, 2024
Contributor
komamitsu
left a comment
komamitsu
left a comment
There was a problem hiding this comment.
LGTM! 👍
I left a minor comment, but it doesn't block this PR from being merged.
| public static final String IMPORT_LOG_ENTRY_STATUS_FIELD = "data_loader_import_status"; | ||
| public static final String TABLE_LOOKUP_KEY_FORMAT = "%s.%s"; | ||
|
|
||
| public static final String LOG_UPDATE_SUCCESS = "Row %s has been updated in table %s.%s"; |
Contributor
There was a problem hiding this comment.
I guess this will be used like String.format(LOG_UPDATE_SUCCESS, namespace, table), but IntelliJ doesn't detect parameter mismatch like String.format(LOG_UPDATE_SUCCESS, namespace) in this way. It might be a slight drawback.
feeblefakie
pushed a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: Peckstadt Yves <peckstadt.yves@gmail.com>
feeblefakie
pushed a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: Peckstadt Yves <peckstadt.yves@gmail.com>
feeblefakie
pushed a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: Peckstadt Yves <peckstadt.yves@gmail.com>
feeblefakie
pushed a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: Peckstadt Yves <peckstadt.yves@gmail.com>
feeblefakie
pushed a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: Peckstadt Yves <peckstadt.yves@gmail.com>
feeblefakie
pushed a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: Peckstadt Yves <peckstadt.yves@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds enum, constants (messages) and DTO classes that will be used in the data loader.
They are handled in separate PR now so that we can speed up the merge and start with the core code for the export process.
Related issues and/or PRs
NA
Changes made
Added below for data loader
Checklist
Additional notes (optional)
This PR is part of the on-going process of merging all ScalarDB Data Loader code into the main repository.
Release notes
NA