Add name to NamespacePolicy and TablePolicy #2466
Merged
+60
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
commented
Jan 17, 2025
| * | ||
| * @return the namespace policy name | ||
| */ | ||
| String getName(); |
Collaborator
Author
There was a problem hiding this comment.
Added a name to NamespacePolicy.
| * | ||
| * @return the table policy name | ||
| */ | ||
| String getName(); |
Collaborator
Author
There was a problem hiding this comment.
Added a name to TablePolicy as well.
| * @throws ExecutionException if the operation fails | ||
| */ | ||
| default void applyPolicyToNamespace(String policyName, String namespaceName) | ||
| default void createNamespacePolicy( |
Collaborator
Author
There was a problem hiding this comment.
Renamed applyPolicyToNamespace to createNamespacePolicy.
Also, changed the signature of the enableNamespacePolicy, disableNamespacePolicy, and getNamespacePolicy methods to specify the namespace policy name.
| * @throws ExecutionException if the operation fails | ||
| */ | ||
| default void applyPolicyToTable(String policyName, String namespaceName, String tableName) | ||
| default void createTablePolicy( |
Collaborator
Author
There was a problem hiding this comment.
Renamed applyPolicyToTable to createTablePolicy.
Also, changed the signature of the enableTablePolicy, disableTablePolicy, and getTablePolicy methods to specify the table policy name.
feeblefakie
pushed a commit
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a name to
AbacAdmin.NamespacePolicyandAbacAdmin.TablePolicy. Additionally, it modifies some method names and signatures ofAbacAdminaccordingly.Related issues and/or PRs
Changes made
NamespacePolicy.TablePolicy.applyPolicyToNamespacetocreateNamespacePolicy.enableNamespacePolicy,disableNamespacePolicy, andgetNamespacePolicymethods to specify the namespace policy name.applyPolicyToTabletocreateTablePolicy.enableTablePolicy,disableTablePolicy, andgetTablePolicymethods to specify the table policy name.Checklist
Additional notes (optional)
N/A
Release notes
N/A