Skip to content

Remove unnecessary error code #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

Remove unnecessary error code #2485

merged 1 commit into from
Jan 29, 2025

Conversation

@brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jan 29, 2025

Description

This PR removes an unnecessary error code.

Related issues and/or PRs

N/A

Changes made

  • Removed an unnecessary error code.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 self-assigned this Jan 29, 2025
Torch3333
Torch3333 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

josh-wong
josh-wong approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@josh-wong josh-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!🙇🏻‍♂️

@brfrn169 brfrn169 merged commit d96be11 into 3.14 Jan 29, 2025
48 checks passed
@brfrn169 brfrn169 deleted the remove-unnecessary-error-code branch January 29, 2025 05:54
feeblefakie pushed a commit that referenced this pull request Jan 29, 2025
@brfrn169
Remove unnecessary error code (#2485)
80f2d79
This was referenced Jan 29, 2025
Merged
Merged
brfrn169 added a commit that referenced this pull request Jan 29, 2025
@brfrn169
Remove unnecessary error code (#2485)
816f155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Torch3333 Torch3333 Torch3333 approved these changes

@josh-wong josh-wong josh-wong approved these changes

Assignees

@brfrn169 brfrn169

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brfrn169 @Torch3333 @josh-wong