Optimize JDBC storage by using Connection.setReadOnly() #2651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes JDBC storage by enabling connection read-only mode for Get and Scan operations to potentially improve performance.
- Updated tests to assert the default read-only flag and verify that connection.setReadOnly(true) is invoked.
- Modified the JdbcUtils and JdbcDatabase classes to set default read-only configuration and mark connections as read-only on demand.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/src/test/java/com/scalar/db/storage/jdbc/JdbcUtilsTest.java | Added assertions for default read-only flag in the data source. |
| core/src/test/java/com/scalar/db/storage/jdbc/JdbcDatabaseTest.java | Verified that connection.setReadOnly(true) is called during Get and Scan operations. |
| core/src/main/java/com/scalar/db/storage/jdbc/JdbcUtils.java | Configured the data source to have a default read-only flag of false. |
| core/src/main/java/com/scalar/db/storage/jdbc/JdbcDatabase.java | Set the connection to read-only for Get and Scan operations before using the JDBC service. |
| Connection connection = null; | ||
| try { | ||
| connection = dataSource.getConnection(); | ||
| connection.setReadOnly(true); |
There was a problem hiding this comment.
[nitpick] The call to setReadOnly(true) is duplicated in both the get and scan methods. Consider extracting this operation into a helper method to reduce duplication and improve maintainability.
brfrn169
force-pushed
the
optimize-jdbc-storage-by-using-setReadOnly
branch
from
2577763 to
11cacf1
Compare
Torch3333
reviewed
May 16, 2025
Collaborator
Author
@Torch3333 Thanks for your feedback! Fixed in febd642. |
brfrn169
added a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the JDBC storage to use
Connection.setReadOnly()to optimize read operations.For details about the
Connection.setReadOnly()method, see:https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#setReadOnly-boolean-
Related issues and/or PRs
N/A
Changes made
Connection.setReadOnly()for the Get and Scan operations.Checklist
Additional notes (optional)
N/A
Release notes
N/A