Skip to content

Fix build error in data-loader #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Fix build error in data-loader #2757

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a8a8c7
Fix build error in data-loader
brfrn169 Jun 12, 2025
68cec22
Merge branch 'master' into fix-build-error-in-data-loader
brfrn169 Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions data-loader/cli/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ javadoc {

// Build a fat jar
shadowJar {
mustRunAfter distZip, distTar
Copy link

Copilot AI Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'mustRunAfter distZip, distTar' statement forces shadowJar to execute after distZip and distTar, which contradicts the intended dependency flow since these tasks depend on shadowJar's output. Consider instead having distZip, distTar, and startScripts declare an explicit dependency on shadowJar using 'dependsOn' to ensure the correct execution order.

Suggested change
mustRunAfter distZip, distTar

Copilot uses AI. Check for mistakes.
archiveClassifier.set("")
manifest {
attributes 'Main-Class': 'com.scalar.db.dataloader.DataLoaderCli'
Expand Down