Backport to branch(3) : Bump the dependencies group with 6 updates #182
Conversation
* Bump the dependencies group with 6 updates --- updated-dependencies: - dependency-name: io.dropwizard.metrics:metrics-core dependency-version: 4.2.33 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: io.dropwizard.metrics:metrics-jmx dependency-version: 4.2.33 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: io.dropwizard.metrics:metrics-jmx dependency-version: 4.2.33 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: com.scalar-labs:scalardb dependency-version: 3.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: com.scalar-labs:scalardb-schema-loader dependency-version: 3.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: org.apache.logging.log4j:log4j-core dependency-version: 2.25.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: org.apache.logging.log4j:log4j-slf4j-impl dependency-version: 2.25.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: org.apache.logging.log4j:log4j-slf4j-impl dependency-version: 2.25.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: com.scalar-labs:scalardb-schema-loader dependency-version: 3.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com> * Fix errors for log4j and ScalarDB * Fix for the recovery behavior change in ScalarDB --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jun Nemoto <jun.nemoto@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated backport primarily focused on updating several core dependencies to their latest versions, including Log4j, ScalarDB, and Dropwizard Metrics. It also includes a refactoring of how Log4j dependencies are managed across the project, centralizing their declaration. Minor, related code modifications were necessary in an integration test to align with API changes introduced by the ScalarDB update.
Highlights
- Dependency Updates: This pull request updates several key dependencies, including
log4jfrom2.24.3to2.25.0,ScalarDBfrom3.15.3to3.16.0, andDropwizard Metricsfrom4.2.32to4.2.33. - Dependency Management Refactoring: The declaration of
log4j-coreandlog4j-slf4j-impldependencies has been centralized in the rootbuild.gradlefile, applying to all subprojects. This change allowed for the removal of these explicit declarations fromclient/build.gradleandledger/build.gradle. - Integration Test Adjustments: Minor code adjustments were made in an integration test (
GenericContractObjectAndCollectionEndToEndTest.java) to accommodate changes in theScalarDBlibrary, specifically an import path change forCoreErrorand updates to test logic involving transaction states and coordinator table operations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request is an automated backport to bump several dependencies, including log4j, scalarDb, and dropwizardMetrics. The changes also involve refactoring the Gradle build files to centralize the log4j dependencies, which is a good improvement for maintainability. Additionally, an integration test has been updated to align with behavior changes in the new version of scalarDb. The changes appear to be correct and necessary adaptations for the dependency updates. I have not found any issues of medium or higher severity.
| .partitionKey(Key.ofText(SOME_COLUMN_NAME_1, SOME_OBJECT_ID)) | ||
| .clusteringKey(Key.ofText(SOME_COLUMN_NAME_2, SOME_VERSION_ID_0)) | ||
| .intValue("tx_state", TransactionState.ABORTED.get()) | ||
| .intValue(METADATA_TX_STATE, TransactionState.PREPARED.get()) |
There was a problem hiding this comment.
Consider using the constant METADATA_TX_STATE instead of the hardcoded string tx_state to improve code maintainability and readability.
| .intValue(METADATA_TX_STATE, TransactionState.PREPARED.get()) | |
| .intValue(METADATA_TX_STATE, TransactionState.PREPARED.get()) |
2 participants
This is an automated backport of the following:
Please merge this PR after all checks have passed.